add more buttons; remove some sections covered in the docs; general cleanup #8274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
RubenKelevra
commented
Jul 18, 2021
RubenKelevra
commented
- added dynamic buttons for packages/downloads which shows the latest version where possible
- dynamic next milestone buttons
- reordered to have package managers and docker on top, manual downloads afterwards
- remove the docker and the cli section, since they are covered equally in the docs + button links
- added more sections to the navigation, to find stuff easier
- dynamic go requirement version button
- some social media buttons
- general cleanup
Stebalien
reviewed
Jul 19, 2021
|
@RubenKelevra : can you please incorporate the feedback? We'll then get this merged. |
|
@BigLep wrote:
Yeah sorry looks like I overlooked the notification :) |
|
@aschmahmann can do give this a quick look, please? :) |
|
@Stebalien : are you ok to close this one out since you have been involved in the incremental diffs? |
|
Well, the only unchanged thing is the Milestones as buttons. I mean, we could merge it and @aschmahmann can remove them if he feels like that's too much work :) |
|
@BigLep should be good to go now 😎 |
Stebalien
requested changes
Aug 26, 2021
|
Could this be rebased on master, tests should then be able to pass. 🙇 |
RubenKelevra
force-pushed
the
patch-6
branch
from
7f16f21
to
37ec1a3
Compare
|
We'll have to merge after #8401. |
…leanup - added dynamic buttons for packages/downloads which shows the latest version where possible - dynamic next milestone buttons - reordered to have package managers and docker on top, manual downloads afterwards - remove the docker and the cli section, since they are covered equally in the docs + button links - added more sections to the navigation, to find stuff easier - dynamic go requirement version button - some social media buttons - general cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.