Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cosmetic fixups in examples #8325

Merged
merged 4 commits into from
Aug 27, 2021
Merged

Cosmetic fixups in examples #8325

merged 4 commits into from
Aug 27, 2021

Conversation

petar
Copy link
Contributor

@petar petar commented Aug 4, 2021

  • fix example go.sum
  • use common example folder
  • spell out complete source of second example (go ipfs with experimental features)

@petar petar requested a review from aschmahmann August 4, 2021 13:40
@BigLep BigLep linked an issue Aug 5, 2021 that may be closed by this pull request
25 tasks
@petar
Copy link
Contributor Author

petar commented Aug 5, 2021

@aschmahmann Addressed comments here.

@petar
Copy link
Contributor Author

petar commented Aug 6, 2021

@aschmahmann Added test. Worked out well.

@aschmahmann
Copy link
Contributor

The test seems to pass, but it doesn't seem to be running in CI. Once it's running then it looks like we're good to go.

@petar
Copy link
Contributor Author

petar commented Aug 6, 2021

The test seems to pass, but it doesn't seem to be running in CI. Once it's running then it looks like we're good to go.

It seems to have passed.

@Stebalien
Copy link
Member

Can we make the tests run when we run make test?

@aschmahmann aschmahmann merged commit c9cc09f into master Aug 27, 2021
@aschmahmann aschmahmann deleted the fix/examples branch August 27, 2021 15:55
aschmahmann pushed a commit that referenced this pull request Sep 27, 2021
* test the examples in CI
* combine the two examples into a single one

(cherry picked from commit c9cc09f)
aschmahmann pushed a commit that referenced this pull request Sep 27, 2021
* test the examples in CI
* combine the two examples into a single one

(cherry picked from commit c9cc09f)
aschmahmann pushed a commit that referenced this pull request Sep 27, 2021
* test the examples in CI
* combine the two examples into a single one

(cherry picked from commit c9cc09f)
@aschmahmann aschmahmann mentioned this pull request Sep 30, 2021
62 tasks
@aschmahmann aschmahmann mentioned this pull request Dec 1, 2021
80 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix release template issues/gaps (v0.9 and v0.10 edition)
3 participants