fix(corehttp): adjust peer counting metrics #8577
Conversation
| if actual["/ip4/tcp"] != float64(3) { | ||
| t.Fatalf("expected 3 peers, got %f", actual["/ip4/tcp"]) | ||
| totalPeers := peersTransport["/ip4/tcp"] + peersTransport["/ip4/udp/quic"] | ||
| if totalPeers != 3 { |
There was a problem hiding this comment.
I think this test is fine. However, I'll just note that it still depends on internals of libp2p. This test is creating "contact" to 3 peers, but it does not control what type of connections (and how many) are actually created to each peer (this is libp2p's business). Yet, this test checks for specific types of connections. So, if libp2p were to change and e.g. drop the quic transport, this test will fail again. In any event, I think the test is fine as it is, since it is unlikely libp2p will drop tcp or quic anytime soon.
There was a problem hiding this comment.
Agreed. I tried to retain the spirit of the test since this metric provides a map that collects transports, not just peer counts, but I'm also fine removing this level of specificity.
(cherry picked from commit 9d197ca)
(cherry picked from commit 9d197ca)
Following upstream fix in libp2p/go-libp2p-swarm@0538806.
Fixes #8135.