Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build after Go 1.17 and Prometheus upgrades #8916

Merged
merged 2 commits into from
Apr 27, 2022
Merged

Fix build after Go 1.17 and Prometheus upgrades #8916

merged 2 commits into from
Apr 27, 2022
+99 −18

Conversation

guseggert
Copy link
Contributor

@guseggert guseggert commented Apr 27, 2022 •
edited
Loading

  • A merge brought in changes to go.mod which needed to be tidied
  • Upgrading to Go 1.17 and the new Prometheus client that supports Go 1.17 caused Prometheus to publish some new Go runtime metrics which broke a sharness test
    • Uncaught by CI because the Prom upgrade was tested against Go 1.16 but merged into master which had upgraded to Go 1.17 in the meantime
    • We have no plans to require branches be up-to-date prior to merge though, due to other tradeoffs (requires more coordination with PR authors, and that extra friction isn't worth it)

@guseggert
fix: go mod tidy
9578023
@guseggert
fix: update expected prometheus metrics
e528859 
Go 1.17 includes some new runtime metrics that are automatically
published by the Prometheus client, so this adds them to the expected
metric list so that the tests pass and we don't accidentally drop them
in the future.
@guseggert guseggert marked this pull request as ready for review April 27, 2022 11:20
@Jorropo Jorropo enabled auto-merge (squash) April 27, 2022 11:37
Jorropo
Jorropo approved these changes Apr 27, 2022
View reviewed changes
Copy link
Contributor

@Jorropo Jorropo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jorropo Jorropo merged commit d4879a4 into master Apr 27, 2022
@Jorropo Jorropo deleted the fix/go-mod-tidy branch April 27, 2022 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jorropo Jorropo Jorropo approved these changes

@schomatis schomatis Awaiting requested review from schomatis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guseggert @Jorropo