Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update ipns module to v9 and fix double verification of records #396

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Jan 18, 2024

Updates IPNS module to version that is capable of round-tripping records created with non-nano-second validity times - adds an interop test to ensure there are no regressions.

Improves error messaging for records (e.g. the message now says that a record failed to validate rather than just "not found").

Updates @helia/delegated-routing-v1-http-api-client to version that can skip verification of incoming records.

Fixes #394 and #395

Updates IPNS module to version that is capable of round-tripping records
created with non-nano-second validity times.

Updates `@helia/delegated-routing-v1-http-api-client` to version that
can skip verification of incoming records.

Fixes #394 and #395
@achingbrain achingbrain requested a review from a team as a code owner January 18, 2024 13:49
Copy link
Member

@2color 2color left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achingbrain achingbrain merged commit f2853f8 into main Jan 18, 2024
19 checks passed
@achingbrain achingbrain deleted the fix/update-ipns-module-and-fix-double-verify branch January 18, 2024 15:10
This was referenced Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPNS records are validated twice when resolved
2 participants