Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Handle metrics breakage issue in mv3 #1171

Closed
Tracked by #1169
SgtPooki opened this issue Mar 3, 2023 · 4 comments
Closed
Tracked by #1169

fix: Handle metrics breakage issue in mv3 #1171

SgtPooki opened this issue Mar 3, 2023 · 4 comments
Labels
status/duplicate A question or request for support

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Mar 3, 2023

From @whizzzkid:

We might need to revisit/refactor ignite-metrics, because mv3 removes the background_page context and replaces it with service-wroker context, i.e. reporting metrics from the background would be the same constraint as if running from within a service worker.

Metrics might break on ipfs-companion, because countly sdk needs window context and mv3 replaces background page with a service-worker context, i.e. no more countly:

Discussed at:

@SgtPooki
Copy link
Member Author

SgtPooki commented Mar 3, 2023

FYI: webpack has functionality to replace text during builds via the define plugin: https://webpack.js.org/plugins/define-plugin/#usage

This may help, though it would require us to rebuild our own countly sdk. We could also use patch-package, but ideally countly would produce a decent SDK that could be consumed in multiple environments.

@whizzzkid whizzzkid mentioned this issue Mar 4, 2023
13 tasks
@whizzzkid
Copy link
Contributor

Being tracked in #1169

@BigLep
Copy link
Contributor

BigLep commented Mar 6, 2023

@whizzzkid : what was the verdict here?

@whizzzkid
Copy link
Contributor

@BigLep This issue is being tracked in #1169 as this is a blocker for that. So this is essentially a duplicate issue.

@whizzzkid whizzzkid added the status/duplicate A question or request for support label Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/duplicate A question or request for support
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

3 participants