Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MV3 Beta Bug] Local Redirects Should not generate infinite redirect regex #1209

Closed
Tracked by #1152
whizzzkid opened this issue May 25, 2023 · 0 comments
Closed
Tracked by #1152

[MV3 Beta Bug] Local Redirects Should not generate infinite redirect regex #1209

whizzzkid opened this issue May 25, 2023 · 0 comments
Assignees
@whizzzkid
Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs

Comments

@whizzzkid
Copy link
Contributor

Under certain circumstances a regex pattern can exist which catches all the URLs and redirects requests till browser crashes.

It's handled here: https://github.com/ipfs/ipfs-companion/blob/rc/3.0-mv3/add-on/src/lib/redirect-handler/blockOrObserve.ts#L129-L133

however this does not work for http urls and only for https
@whizzzkid whizzzkid added kind/bug A bug in existing code (including security flaws) area/MV3 Issues related to Manifest V3 version mv3-beta-bugs labels May 25, 2023
@whizzzkid whizzzkid self-assigned this May 25, 2023
@whizzzkid whizzzkid mentioned this issue May 26, 2023
Merged
@whizzzkid whizzzkid mentioned this issue Aug 2, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@whizzzkid whizzzkid

Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) mv3-beta-bugs
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whizzzkid