Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MV3 handling of ?uri= creates too many rules #1254

Closed
Tracked by #1253 ...
lidel opened this issue Aug 3, 2023 · 0 comments
Closed
Tracked by #1253 ...

MV3 handling of ?uri= creates too many rules #1254

lidel opened this issue Aug 3, 2023 · 0 comments
Assignees

Comments

@lidel
Copy link
Member

lidel commented Aug 3, 2023

MV3 3.0.0.1114 produces one rule per URI:

origin: '^https?\\:\\/\\/dweb\\.link\\/ipfs\\/\\?uri\\=ipfs%3A%2F%2FQmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR%3FargTest%23',
destination: 'https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR?argTest#'

This will balloon the number of created rules, making them very hard to inspect.

Perhaps we could have a single catch-all rule for ?uri=* which opens a router page under chrome-extension:// similar to recovery one, and JS there redirecting to the final URI via window.location.replace?

@lidel lidel added need/triage Needs initial labeling and prioritization mv3-beta-bugs labels Aug 3, 2023
@whizzzkid whizzzkid self-assigned this Aug 4, 2023
@SgtPooki SgtPooki removed the need/triage Needs initial labeling and prioritization label Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants