Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MV3 Beta Bugs] Invalid "Target" in Redirect Rules UI #1277

Closed
Tracked by #1152
lidel opened this issue Sep 14, 2023 · 0 comments · Fixed by #1280
Closed
Tracked by #1152

[MV3 Beta Bugs] Invalid "Target" in Redirect Rules UI #1277

lidel opened this issue Sep 14, 2023 · 0 comments · Fixed by #1280
Labels
area/MV3 Issues related to Manifest V3 version kind/discussion Topical discussion; usually not changes to codebase mv3-beta-bugs

Comments

@lidel
Copy link
Member

lidel commented Sep 14, 2023

This is not blocking #1182, just something to improve in follow-up PR.

The way rules for subdomain gateways are presented make no sense, looks like a bug:

2023-09-14_21-51

To reproduce above rules, try opening:

  1. https://dweb.link/ipns/ipfs.tech
  2. https://blog.ipfs.tech/
  3. https://docs-ipfs-tech.ipns.dweb.link/ → the Target here is due to a separate bug described in [MV3 Beta Bugs] Single catch-all rule per subdomain gateway #1278

Suggestions:

  • remove <resource-path>: it is not used correctly, never indicates actual content path
  • keep things simple, use the original identifier of the capture group in regex (\1, \2, or \3), this way you don't need to have different label for one of 3 cases, and its the same as the actual rule
@lidel lidel added need/triage Needs initial labeling and prioritization area/MV3 Issues related to Manifest V3 version mv3-beta-bugs labels Sep 14, 2023
@whizzzkid whizzzkid added kind/discussion Topical discussion; usually not changes to codebase and removed need/triage Needs initial labeling and prioritization labels Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/MV3 Issues related to Manifest V3 version kind/discussion Topical discussion; usually not changes to codebase mv3-beta-bugs
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants