Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#x-ipfs-companion-no-redirect opt-out does not work in 3.0.0 #1299

Open
lidel opened this issue Oct 4, 2023 · 0 comments
Open

#x-ipfs-companion-no-redirect opt-out does not work in 3.0.0 #1299

lidel opened this issue Oct 4, 2023 · 0 comments
Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now post-mv3 Tasks to be done after MV3 release

Comments

@lidel
Copy link
Member

lidel commented Oct 4, 2023

The #x-ipfs-companion-no-redirect opt-out described in https://github.com/ipfs/ipfs-companion#toggle-redirects-globally-or-per-site does not seem to work anymore

@whizzzkid not sure if this works, or is worth supporting in MV3.
If not, maybe we should remove it from readme and docs?

I think the opt-out is used on https://ipfs.github.io/public-gateway-checker/ but if we no longer redirect subresources (only top-level documents), we could remove it from URLs there too.

@lidel lidel added kind/bug A bug in existing code (including security flaws) need/triage Needs initial labeling and prioritization area/MV3 Issues related to Manifest V3 version labels Oct 4, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Oct 5, 2023
@whizzzkid whizzzkid added P3 Low: Not priority right now post-mv3 Tasks to be done after MV3 release and removed need/triage Needs initial labeling and prioritization labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/MV3 Issues related to Manifest V3 version kind/bug A bug in existing code (including security flaws) P3 Low: Not priority right now post-mv3 Tasks to be done after MV3 release
Projects
No open projects
Status: Needs Grooming
Development

No branches or pull requests

2 participants