Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinning fails for paths with URL-unsafe characters #303

Closed
lidel opened this issue Oct 28, 2017 · 1 comment
Closed

Pinning fails for paths with URL-unsafe characters #303

lidel opened this issue Oct 28, 2017 · 1 comment
Assignees
@lidel
Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up

Comments

@lidel
Copy link
Member

lidel commented Oct 28, 2017

To reproduce, visit and try to pin via browser action button:

https://ipfs.io/ipfs/Qmb8wsGZNXt5VXZh1pEmYynjB6Euqpq3HYyeAdw2vScTkQ/1%20-%20Barrel%20-%20Part%201

Right now it produces error in Browser Console:

unexpected result of ipfs.pin.ls: Error: no link named "1%20-%20Barrel%20-%20Part%201" under Qmb8wsGZNXt5VXZh1pEmYynjB6Euqpq3HYyeAdw2vScTkQ ({"code":0})

This may be fixable by un-escaping paths before sending them to IPFS API.
If not, an issue needs to be raised in js-ipfs-api or even go-ipfs
@lidel lidel added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue P2 Medium: Good to have, but can wait until someone steps up labels Oct 28, 2017
@lidel
Copy link
Member Author

lidel commented Nov 2, 2017 •
edited
Loading

While we are at it, we probably should use unescaped path while "copying canonical IPFS address" to clipboard as well (as noted in fbaiodias/ipfs-chrome-station#18).

@lidel lidel self-assigned this Nov 6, 2017
@lidel lidel closed this as completed in e8b4c9e Nov 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
exp/novice Someone with a little familiarity can pick up good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) P2 Medium: Good to have, but can wait until someone steps up
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lidel