Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with ipfs-share-files #700

Closed
lidel opened this issue Mar 21, 2019 · 1 comment
Closed

Integration with ipfs-share-files #700

lidel opened this issue Mar 21, 2019 · 1 comment
Labels
exp/novice Someone with a little familiarity can pick up status/deferred Conscious decision to pause or backlog

Comments

@lidel
Copy link
Member

lidel commented Mar 21, 2019

Part of UX improvements for sharing local files (#342)

Shipping ipfs-share-files with Companion did not happen for two reasons:

  1. We had to stop bundling Web UI due to reproducibility issues, and for the same reason Share app won’t be bundled any time soon.
  2. ipfs-share-files itself requires some improvements around content discovery speed (at infra, websockets, webrtc), which did not land yet

I think we will switch approach and instead of opening uploaded resource at the gateway, display "success screen" with direct link to the gateway and “get share link” option that copies link to share.ipfs.io. This would also address #423.

@lidel lidel added UX exp/novice Someone with a little familiarity can pick up status/deferred Conscious decision to pause or backlog labels Mar 21, 2019
@lidel
Copy link
Member Author

lidel commented Dec 24, 2019

No longer relefant: after successful import we open resource in Web UI (#810) and link is automatically copied to clipboard, removing the need for ipfs-companion-specific UI.

If ipfs-share-files gets picked up again, we could use its URLs for shareable links, but for now this can be closed.

@lidel lidel closed this as completed Dec 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
exp/novice Someone with a little familiarity can pick up status/deferred Conscious decision to pause or backlog
Projects
None yet
Development

No branches or pull requests

1 participant