Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add favicon to welcome, options, quick-import pages #906

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

jessicaschilling
Copy link
Contributor

Adds favicon as inline data to <head> of the following pages, so Firefox has something to use (Chrome seems to be falling back to the extension's icon in absence of explicit favicon):

  • Welcome (dist/landing-pages/welcome/index.html)
  • Options (dist/options/options.html)
  • Quick import (dist/popup/quick-import.html)

Closes #902.

@jessicaschilling
Copy link
Contributor Author

@lidel - this may be the littlest PR you see all week.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lidel lidel changed the title Adds explicit inline favicon to welcome, options, quick-import pages fix: add favicon to welcome, options, quick-import pages Jun 30, 2020
@lidel lidel merged commit b89788a into master Jun 30, 2020
@lidel lidel deleted the bug/firefox-favicons branch June 30, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing favicon
2 participants