feat: remember manual opt-ins and opt-outs per site #929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves the way we handle manual opt-out performend per site by the user by storing both manual opt-outs and opt-ins. This way we are able to tweak implicit default per website while respecting preexisting user choices. Also, in the future we may run opt-in metrics that compare lengths of both lists to gain better insight into user's behavior. Closes #921
jsonsivar
reviewed
Oct 15, 2020
add-on/src/lib/options.js
Outdated
| const { enabledOn, disabledOn } = await storage.get(['enabledOn', 'disabledOn']) | ||
| for (const fqdn of [ | ||
| 'proto.school', // https://github.com/ipfs-shipyard/ipfs-companion/issues/921 | ||
| 'app.fleek.co' // TODO: confirm if ok |
There was a problem hiding this comment.
Janison from Fleek here - this looks good. Thanks for this. cc @studna
jessicaschilling
suggested changes
Oct 15, 2020
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
Co-authored-by: Jessica Schilling <jessica@protocol.ai>
We only support hostnames
|
@jessicaschilling merged your suggestions, but removed "URI" from preference label |
jessicaschilling
approved these changes
Oct 15, 2020
This ensures that toggling a subdomain creates a rule for subdomain and does not impact existing rules for parents. If there is no direct opt-in or opt-out, parents are matched. If there is opt-out for a parent, but also a direct opt-in for subdomain, direct opt-in takes precedence.
|
I'm going to ship this to Beta soon, so we can dogfood it more, |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the way we handle manual opt-out performed per site by the user by storing both opt-out and opt-in decisions made by the user.
Changes
Explicit opt-in and opt-out lists in Preferences
noIntegrationsHostnames.disabledOn.Menu toggle adds/moves hostname between lists
however the expectation is that most of the time users will not touch them.
Overriding implicit default per website
Short term (this PR)
proto.schoolto opt-out list if it was not already present on either of lists.app.fleek.co– feat: remember manual opt-ins and opt-outs per site #929 (review) (does not work from local gateway atm due to stripe.com limitation)Long term (separate PR)
We will be looking into supporting opt-out based on HTTP header or DNS, so any IPFS-powered website can change the implicit behaviour to opt-out. Tracked in #930
Closes #921 cc @terichadbourne @jessicaschilling