Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toolbar button does not display in private browsing #98

Closed
chungy opened this issue Mar 29, 2016 · 1 comment
Closed

Toolbar button does not display in private browsing #98

chungy opened this issue Mar 29, 2016 · 1 comment
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@chungy
Copy link

chungy commented Mar 29, 2016

The extension otherwise functions, such as redirecting public gateways to the localhost one, but there's no button displayed to copy a public link or open the WebUI.

This also affects Firefox when the browser is configured to "Never remember history" -- in which case, the button never displays at all.

@lidel lidel added the kind/bug A bug in existing code (including security flaws) label Mar 29, 2016
@lidel
Copy link
Member

lidel commented Mar 29, 2016

I agree, it does not make much sense to hide UI while the low level redirect is active.
The button should be visible in private browsing, as it does not decrease privacy in any way.

Will fix in next version.

Ref. https://developer.mozilla.org/en-US/Add-ons/SDK/High-Level_APIs/private-browsing

@lidel lidel closed this as completed in 16cd25e Mar 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Development

No branches or pull requests

2 participants