Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check ports is always triggered #1409

Closed
hacdias opened this issue Apr 17, 2020 · 0 comments · Fixed by #1410
Closed

Check ports is always triggered #1409

hacdias opened this issue Apr 17, 2020 · 0 comments · Fixed by #1410
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP

Comments

@hacdias
Copy link
Member

hacdias commented Apr 17, 2020

Describe the bug

checkPorts is always being triggered after stopping/restarting the daemon. get-port is always telling us the ports are unavailable even if they are, in fact, available. This affects the latest released version of IPFS Desktop, as well as master. There are a few issues on their repo that might be related.

As a reference, see #1372, which seems to be the opposite problem: it does not detect a used port!

To Reproduce
Steps to reproduce the behavior:

  1. Click 'Restart' or 'Stop' then 'Start'
  2. See error

Expected behavior

IPFS should restart.

Screenshots

N/A

Desktop (please complete the following information):

  • OS: macOS
  • Browser: N/A
  • Version: master and latest

Additional context

N/A
@hacdias hacdias added need/triage Needs initial labeling and prioritization kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP and removed need/triage Needs initial labeling and prioritization labels Apr 17, 2020
@hacdias hacdias mentioned this issue Apr 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: use portfinder instead of get-port ipfs/ipfs-desktop
1 participant
@hacdias