Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash when click to "advanced -> open repository folder" #1686

Closed
ghost opened this issue Oct 9, 2020 · 2 comments · Fixed by #1687
Closed

Crash when click to "advanced -> open repository folder" #1686

ghost opened this issue Oct 9, 2020 · 2 comments · Fixed by #1687
Milestone
v0.13.1

Comments

@ghost
Copy link

ghost commented Oct 9, 2020

Please describe what you were doing when this error happened.

Specifications

  • OS: win32
  • IPFS Desktop Version: 0.13.0
  • Electron Version: 9.3.2
  • Chrome Version: 83.0.4103.122

Error

TypeError: shell.openItem is not a function
    at click (C:\Program Files\IPFS Desktop\resources\app.asar\src\tray.js:145:32)
    at MenuItem.click (electron/js2c/browser_init.js:65:1624)
    at Function.executeCommand (electron/js2c/browser_init.js:73:1102)
@ghost ghost changed the title Crash when try to open repository folder Crash when click to "open repository folder Oct 9, 2020
@ghost ghost changed the title Crash when click to "open repository folder Crash when click to "advanced -> open repository folder" Oct 9, 2020
@ghost
Copy link
Author

ghost commented Oct 9, 2020

Maybe link to the folder is wrong:
C:\Program Files\IPFS Desktop\resources\app.asar\src - doesn't exist
C:\Program Files\IPFS Desktop\resources\app.asar.unpacked\src - this path exist

@jessicaschilling
Copy link
Contributor

Hi - this is a known issue and is being worked in #1687.

@jessicaschilling jessicaschilling mentioned this issue Oct 9, 2020
Merged
@jessicaschilling jessicaschilling added this to the v0.13.1 milestone Oct 9, 2020
This was referenced Nov 18, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.13.1
Development

Successfully merging a pull request may close this issue.

fix: openItem errors ipfs/ipfs-desktop
1 participant
@jessicaschilling