Skip to content

remove js-ipfs related deps #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
SgtPooki opened this issue Jun 12, 2023 · 2 comments
Open

remove js-ipfs related deps #137

SgtPooki opened this issue Jun 12, 2023 · 2 comments
Assignees
@SgtPooki

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jun 12, 2023 •
edited
Loading 

### Tasks
- [ ] remove ipfs
- [ ] remove ipfs-core-utils
- [ ] remove ipfs-provider
- [ ] remove is-ipfs
@SgtPooki SgtPooki mentioned this issue Jun 12, 2023
Open
@SgtPooki SgtPooki self-assigned this Jun 12, 2023
@github-project-automation github-project-automation bot moved this to Needs Grooming in IPFS-GUI (PL EngRes) Jun 12, 2023
@SgtPooki
Copy link
Member Author

the IPNS publishing fails when I remove the js-ipfs support from ipfsdCtl in ipfs-backend.js for e2e tests, and pass when I leave it alone:

results of npx playwright test -c ./test/e2e --repeat-each 10

 5 failed
    ipns.test.js:34:5 › IPNS publishing › Settings screen › should support adding new keys ─────────
    ipns.test.js:29:5 › IPNS publishing › Settings screen › should list IPNS keys ──────────────────
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
  355 passed (3.0m)

@SgtPooki
Copy link
Member Author

I reverted changes to ipfs-backend.js and re-ran npx playwright test -c ./test/e2e --repeat-each 10 and got

  5 failed
    explore.test.js:181:5 › Explore screen › Inspecting CID › should open dag-pb unixFS XKCD Archives
    explore.test.js:181:5 › Explore screen › Inspecting CID › should open dag-pb unixFS XKCD Archives
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action
    ipns.test.js:85:5 › IPNS publishing › Files screen › should have functional "Publish to IPNS" context action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SgtPooki SgtPooki

Labels
None yet
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Needs Grooming
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SgtPooki