Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate/display QR code for sharing #1358

Closed
otboss opened this issue Dec 8, 2019 · 5 comments · Fixed by #2320
Closed

Generate/display QR code for sharing #1358

otboss opened this issue Dec 8, 2019 · 5 comments · Fixed by #2320
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up released status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-visual Visual design ONLY, not part of a larger UX effort

Comments

@otboss
Copy link

otboss commented Dec 8, 2019

Showing a QR Code when the user clicks the share file option
@hacdias
Copy link
Member

hacdias commented Dec 16, 2019

That can be a great idea. I'm moving this to right repository.

@hacdias hacdias transferred this issue from ipfs/ipfs-desktop Dec 16, 2019
@jessicaschilling jessicaschilling changed the title [Feature Suggestion] - Generate and display QR Code containing file hash Generate/display QR code of file hash Apr 7, 2020
@jessicaschilling jessicaschilling added exp/intermediate Prior experience is likely helpful effort/hours Estimated to take one or several hours good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-visual Visual design ONLY, not part of a larger UX effort labels Apr 7, 2020
@jessicaschilling jessicaschilling mentioned this issue Dec 14, 2020
Closed
@SgtPooki SgtPooki moved this to To do in IPFS-GUI (PL EngRes) Jul 19, 2022
@lidel
Copy link
Member

lidel commented Jan 21, 2025 •
edited
Loading

Useful feature for sharing to mobile or a friend.

  • The QR should be URL of selected file/directory at Public Gateway set on Settings page.
  • We dont need to add new UI, we should just add QR code to the existing "Share link" UI modal that is displayed via context menu on "Files" screen:

    Image

@lidel lidel changed the title Generate/display QR code of file hash Generate/display QR code for sharing Jan 21, 2025
@badgooooor
Copy link
Contributor

Hi, @lidel can I take this issue? I just tried added it quickly.

Image

@badgooooor badgooooor mentioned this issue Jan 25, 2025
Merged
@mansijoshi17
Copy link

Hi, @lidel Can I work on this issue if it's not done?

@SgtPooki SgtPooki linked a pull request Jan 29, 2025 that will close this issue
feat: add QR Code to ShareModal #2320
Merged
@ipfs-gui-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 4.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/hours Estimated to take one or several hours exp/intermediate Prior experience is likely helpful good first issue Good issue for new contributors help wanted Seeking public contribution on this issue kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up released status/ready Ready to be worked topic/design-front-end Front-end implementation of UX/UI work topic/design-visual Visual design ONLY, not part of a larger UX effort
Projects
No open projects
IPFS-GUI (PL EngRes)
Status: Needs Grooming
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add QR Code to ShareModal badgooooor/ipfs-webui
7 participants
@lidel @jessicaschilling @hacdias @badgooooor @otboss @mansijoshi17 @ipfs-gui-bot