Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to Github Actions #1595

Closed
4 tasks
lidel opened this issue Aug 21, 2020 · 0 comments · Fixed by #1763 · May be fixed by Jsn2win/ipfs-webui#8
Closed
4 tasks

Move to Github Actions #1595

lidel opened this issue Aug 21, 2020 · 0 comments · Fixed by #1763 · May be fixed by Jsn2win/ipfs-webui#8
Labels
effort/hours Estimated to take one or several hours exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Aug 21, 2020

We had success with moving to github actions in ipfs-desktop, we should do the same here.

Side issue: CI tests do not run on PRs from forks

Right now testing and publishing release is handled by the same circleCI job, which is limited to local branches.
This means the current setup does not run tests on PRs submitted by community, such as #1572

TODO

@lidel lidel added kind/bug A bug in existing code (including security flaws) P0 Critical: Tackled by core team ASAP kind/maintenance Work required to avoid breaking changes or harm to project's status quo need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) exp/wizard Extensive knowledge (implications, ramifications) required effort/hours Estimated to take one or several hours labels Aug 21, 2020
@lidel lidel self-assigned this Oct 29, 2020
@lidel lidel added P1 High: Likely tackled by core team if no one steps up and removed P0 Critical: Tackled by core team ASAP labels Jan 7, 2021
@lidel lidel removed their assignment Feb 17, 2021
@lidel lidel added the help wanted Seeking public contribution on this issue label Feb 17, 2021
@lidel lidel changed the title CI tests do not run on PRs from forks Move to Github Actions Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
effort/hours Estimated to take one or several hours exp/wizard Extensive knowledge (implications, ramifications) required help wanted Seeking public contribution on this issue kind/bug A bug in existing code (including security flaws) kind/maintenance Work required to avoid breaking changes or harm to project's status quo need/analysis Needs further analysis before proceeding need/maintainers-input Needs input from the current maintainer(s) P1 High: Likely tackled by core team if no one steps up
Projects
None yet
1 participant