Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect backend support for remote pinning #1680

Closed
lidel opened this issue Oct 27, 2020 · 1 comment
Closed

Detect backend support for remote pinning #1680

lidel opened this issue Oct 27, 2020 · 1 comment
Assignees
@rafaelramalho19
Labels
area/pinning Integrating pinning into GUI apps effort/days Estimated to take multiple days, but less than a week exp/wizard Extensive knowledge (implications, ramifications) required P0 Critical: Tackled by core team ASAP

Comments

@lidel
Copy link
Member

lidel commented Oct 27, 2020

We will be shipping Pinning Services (PS) integration (ipfs/ipfs-gui#91) soon and need a way of detecting if backend supports PS to enable/disable related functionality.

@jessicaschilling @rafaelramalho19 and @lidel discussed this today and our current plan is to:

  1. Add PS support detection
  2. Disable / hide UI/features that require ipfs.pin.remote APIs
  3. Merge epic/pinning-services branch to master

Detection logic

@aschmahmann suggested and we could leverage ipfs.commands call to get a listing of commants supported by the current backend:

const remotePinningSupported = (await ipfsCompanion.ipfs.commands()).Subcommands.find(c=>c.Name==='pin').Subcommands.some(c=>c.Name==='remote')
@lidel lidel added P0 Critical: Tackled by core team ASAP exp/wizard Extensive knowledge (implications, ramifications) required effort/days Estimated to take multiple days, but less than a week area/pinning Integrating pinning into GUI apps labels Oct 27, 2020
@jessicaschilling jessicaschilling mentioned this issue Oct 27, 2020
Closed
@lidel
Copy link
Member Author

lidel commented Jul 23, 2021

Closed as part of ipfs/ipfs-gui#91

@lidel lidel closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rafaelramalho19 rafaelramalho19

Labels
area/pinning Integrating pinning into GUI apps effort/days Estimated to take multiple days, but less than a week exp/wizard Extensive knowledge (implications, ramifications) required P0 Critical: Tackled by core team ASAP
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lidel @rafaelramalho19