Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins don't make sense in latest files ui #1808

Closed
kallisti5 opened this issue Jun 23, 2021 · 1 comment
Closed

Pins don't make sense in latest files ui #1808

kallisti5 opened this issue Jun 23, 2021 · 1 comment
Labels
need/triage Needs initial labeling and prioritization

Comments

@kallisti5
Copy link

kallisti5 commented Jun 23, 2021

Describe the bug
The pins in the webui are pretty non-nonsensical.

By adding files to MFS, doesn't the local node automatically pin all data? Opening folders shows "pinned" data doesn't have a recursive pin.

Maybe the webui isn't identifying recursive pins properly?

Screenshots
"haiku" not pinned + "haikuports" pinned here:
pin_status

Nothing within "haikuports" pinned here:
pin_b

Desktop (please complete the following information):

  • OS: Linux
  • Browser: Opera

Additional context
UI v2.12.3

@kallisti5 kallisti5 added the need/triage Needs initial labeling and prioritization label Jun 23, 2021
@lidel
Copy link
Member

lidel commented Jun 23, 2021

Correct: only direct pins are shown, and indirect pins have no indicator at the moment.
Finding out if a file was pinned indirectly is extremely expensive, however within MFS an optimization is possible where we check each of parent directories.

I'm closing this, as we already track adding that check and indicator for indirect pins in #1736
If you have any suggestions what way of indicating indirect pins feels intuitive, please comment on the linked issue 🙏

@lidel lidel closed this as completed Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/triage Needs initial labeling and prioritization
Projects
None yet
Development

No branches or pull requests

2 participants