Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downloading Multiple Large Files Fails #1885

Closed
hacdias opened this issue Jan 10, 2022 · 1 comment · Fixed by #1890
Closed

Downloading Multiple Large Files Fails #1885

hacdias opened this issue Jan 10, 2022 · 1 comment · Fixed by #1890
Assignees
@hacdias
Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@hacdias
Copy link
Member

hacdias commented Jan 10, 2022 •
edited
Loading

Describe the bug

Downloading large files fails due to the usage of ipfs object add-link. See ipfs/kubo#7421.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Files
  2. Click on multiple large files
  3. Click on 'Download'
  4. See error

Expected behavior
Download the files.

Additional context

See ipfs/kubo#7421. We should move to the MFS API, perhaps through some kind of temporary file on the MFS?

Perhaps something such as /temp/Download {timestamp}. cc @lidel
@hacdias hacdias added the kind/bug A bug in existing code (including security flaws) label Jan 10, 2022
@lidel
Copy link
Member

lidel commented Jan 11, 2022 •
edited
Loading

@hacdias yes, for HAMT our only option is MFS at the moment. My thinking:

  • create directory named /zzzz_{timestamp} (so it is at the end of file list – minimizes the risk of UI jitter in case React refreshed file list that exact moment ;))
  • cp references to files there
  • copy CID of the zzzz directory (ipfs files stat)
  • start download of the archive with CID contents
  • remove the zzzz directory (safe to do asynchronously after the download already started, even if GC is enabled, the root block server its purpose)

@lidel lidel added area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours P1 High: Likely tackled by core team if no one steps up labels Jan 11, 2022
@hacdias hacdias self-assigned this Jan 14, 2022
@hacdias hacdias mentioned this issue Jan 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
area/screen/files Issues related to Files screen effort/hours Estimated to take one or several hours kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: download HAMT-sharded directories ipfs/ipfs-webui
2 participants
@lidel @hacdias