Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: install missing dependencies #1981

Closed
Tracked by #1965
SgtPooki opened this issue Jul 20, 2022 · 3 comments · Fixed by #1983
Closed
Tracked by #1965

chore: install missing dependencies #1981

SgtPooki opened this issue Jul 20, 2022 · 3 comments · Fixed by #1983
Assignees

Comments

@SgtPooki
Copy link
Member

SgtPooki commented Jul 20, 2022

╰─ ✘ 1 ❯ npx --yes npm-check | grep 'Not in the package.json.'
⠙ Checking for unused packages. --skip-unused if you don't want this.(node:57304) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/sgtpooki/code/work/protocol.ai/ipfs/webui/node_modules/@playwright/test/package.json.
Update this package.json to use a subpath pattern like "./*".
(Use `node --trace-deprecation ...` to show where the warning was created)
(node:57304) [DEP0148] DeprecationWarning: Use of deprecated folder mapping "./" in the "exports" field module resolution of the package at /Users/sgtpooki/code/work/protocol.ai/ipfs/webui/node_modules/playwright-chromium/package.json.
Update this package.json to use a subpath pattern like "./*".
eslint-config-react-app                     😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc.js
@typescript-eslint/parser                   😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc.js
@typescript-eslint/eslint-plugin            😟  PKG ERR!  Not in the package.json. Found in: /.eslintrc.js
expect-playwright                           😟  PKG ERR!  Not in the package.json. Found in: /test/e2e/setup/global-after-env.js, /test/e2e/setup/test-environment.js
@SgtPooki
Copy link
Member Author

❯ npm install -D eslint-config-react-app @typescript-eslint/parser @typescript-eslint/eslint-plugin expect-playwright
npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR!
npm ERR! While resolving: ipfs-webui@2.17.3
npm ERR! Found: @typescript-eslint/eslint-plugin@4.15.2
npm ERR! node_modules/@typescript-eslint/eslint-plugin
npm ERR!   peer @typescript-eslint/eslint-plugin@"^4.0.0" from eslint-config-react-app@6.0.0
npm ERR!   node_modules/eslint-config-react-app
npm ERR!     eslint-config-react-app@"^6.0.0" from react-scripts@4.0.3
npm ERR!     node_modules/react-scripts
npm ERR!       react-scripts@"^4.0.3" from the root project
npm ERR!     dev eslint-config-react-app@"*" from the root project
npm ERR!   @typescript-eslint/eslint-plugin@"^4.5.0" from react-scripts@4.0.3
npm ERR!   node_modules/react-scripts
npm ERR!     react-scripts@"^4.0.3" from the root project
npm ERR!   1 more (the root project)
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! dev @typescript-eslint/eslint-plugin@"*" from the root project
npm ERR!
npm ERR! Conflicting peer dependency: @typescript-eslint/parser@5.30.7
npm ERR! node_modules/@typescript-eslint/parser
npm ERR!   peer @typescript-eslint/parser@"^5.0.0" from @typescript-eslint/eslint-plugin@5.30.7
npm ERR!   node_modules/@typescript-eslint/eslint-plugin
npm ERR!     dev @typescript-eslint/eslint-plugin@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /Users/sgtpooki/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/sgtpooki/.npm/_logs/2022-07-20T18_39_47_147Z-debug.log

@lidel
Copy link
Member

lidel commented Jul 25, 2022

@SgtPooki merged #1983 to apply migration to @playwright/test, but it still shows one entry:

$ npx --yes npm-check | grep 'Not in the package.json.'
webpack                                     😟  PKG ERR!  Not in the package.json. Found in: /config-overrides.js

Up to you to decide if this should be closed, or needs more work.

@lidel lidel reopened this Jul 25, 2022
@SgtPooki
Copy link
Member Author

SgtPooki commented Sep 6, 2022

Looks like this is resolved now:

╰─ ✔ ❯ git log -1 | head -1                                              36.27   31.3G   21%   98%  ─╯
commit 83ceac1066a00771fd618e3d58b0617268c7bacc

╭─    ~/code/work/protocol.ai/ipfs/webui    main *4 ?19 ────── ▼  2.30.3 ▼  16.12.0   11:11:36  ─╮
╰─ ✔ ❯ npx --yes npm-check | grep 'Not in the package.json.'             36.27   31.3G   21%   98%  ─╯

╭─    ~/c/work/protocol.ai/ipfs/webui    main *4 ?19 ─ 12s   ▼  2.30.3 ▼  16.12.0   11:11:49  ─╮
╰─ ✘ 1|1 ❯

but we could add this check to our CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants