fix: webui update metrics to opt-out by default (part of 2074) #2084
Conversation
public/locales/en/status.json
Outdated
| @@ -14,7 +14,7 @@ | |||
| }, | |||
| "customApiConfig": "Custom JSON configuration", | |||
| "AskToEnable": { | |||
| "label": "Help improve this app by sending anonymous usage data." | |||
| "label": "We have recently updated our telemetry policy to switch to opt-out metrics. You previously had telemetry collection disabled. You can disable telemetry collection (again) on the settings page.", | |||
There was a problem hiding this comment.
@juliaxbow for visibility
cc @tinytb @lidel
…ed out and updated tests
0xDanomite
force-pushed
the
fix/webui-metrics-opt-out/2074
branch
from
129afdd
to
9d0b85c
Compare
| // Don't track clicks or links as it can include full url. | ||
| // Countly.q.push(['track_clicks']) | ||
| // Countly.q.push(['track_links']) |
There was a problem hiding this comment.
just a note that we can filter out URLs that have CIDs (for any future readers)
…PriorToDefaultOptIn
There was a problem hiding this comment.
A simple question, lgtm otherwise.
@SgtPooki we should host PRs on fleek, like public-gateway-checker does. We already host this on https://webui.ipfs.io/ this way we can test PR specific changes too.
Edit: #2078 I think this issue describes something similar.
| const lastDisabledAt = (consent.length === 0) ? Date.now() : state.lastDisabledAt | ||
| return { ...state, lastDisabledAt, consent } | ||
| const didOptOutCompletely = consent.length === 0 |
There was a problem hiding this comment.
you can also do:
const didOptOutCompletely = consent.length === 0
const lastDisabledAt = didOptOutCompletely ? Date.now() : state.lastDisabledAt This clears up the intentions, but another question that arises is this value will change every time if consent is not granted, do we want that?
yes we should |
## [2.22.0](v2.21.0...v2.22.0) (2023-01-27) CID `bafybeifeqt7mvxaniphyu2i3qhovjaf3sayooxbh5enfdqtiehxjv2ldte` --- ### Features * different countly keys for kubo and webui.ipfs.io deployments ([#2081](#2081)) ([2e766fa](2e766fa)) ### Bug Fixes * import status window UX ([#2075](#2075)) ([4104cc6](4104cc6)) * webui update metrics to opt-out by default (part of 2074) ([#2084](#2084)) ([cac7663](cac7663)) ### Trivial Changes * pull new translations ([#2076](#2076)) ([ad9e4ff](ad9e4ff))
|
🎉 This PR is included in version 2.22.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
fixes: ipfs/ipfs-desktop#2370
fixes: #2085