Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(remotepins): add Functionland Fula #2242

Merged
merged 4 commits into from
Aug 12, 2024
Merged

feat(remotepins): add Functionland Fula #2242

merged 4 commits into from
Aug 12, 2024

Conversation

ehsan6sha
Copy link
Contributor

Functionland Fula is an ipfs compatible DePIN network of 900 (as of 28/06/2024) individually owned and globally distributed nodes. The pinning service report is available at: https://github.com/functionland/pinning-service/blob/main/api.cloud.fx.land.md
Information on Functionland is avaialbe at https://fx.land and also https://www.crunchbase.com/organization/functionland/signals_and_news/timeline

Functionland Fula is an ipfs compatible DePIN network of 900 (as of 28/06/2024) individually owned and globally distributed nodes.
The pinning service report is available at: https://github.com/functionland/pinning-service/blob/main/api.cloud.fx.land.md
@ehsan6sha ehsan6sha requested a review from a team as a code owner June 28, 2024 16:32

This comment was marked as resolved.

ehsan6sha added a commit to ehsan6sha/ipfs-docs that referenced this pull request Jun 28, 2024
Added Functionland Fula network as a pinning service. The corresponding web-ui PR is: ipfs/ipfs-webui#2242
@ehsan6sha
Copy link
Contributor Author

Hey. Any feedback on this?

@SgtPooki
Copy link
Member

SgtPooki commented Jul 3, 2024

@ehsan6sha hey, thanks for submitting this PR and throwing together a pinning service compliance report! we are busy prepping for IPFS Camp but the team will chat about getting this in the webui.

name: 'Functionland',
icon: 'https://bafybeidgnnvgm6i3pfzhjakgzcdwdbvwtmkkx7vzeiyvtk2b4oxis53vhm.ipfs.dweb.link/',
apiEndpoint: 'https://api.cloud.fx.land',
visitServiceUrl: 'https://docs.fx.land/pinning-service/ipfs-pinning-service-api'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ehsan6sha what is the ETA for general availability?

The docs at https://docs.fx.land/pinning-service/ipfs-pinning-service-api#authentication state it is invite-only, and https://cloud.fx.land/ is a broken link.

WebUI is shipping inside IPFS Desktop, and as bare minimum for reviewing this PR, a regular user needs to be able to use it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @lidel for mentioning that . We were planning to officially announce the release later, but I made it live now. the website and instructions are updated and easy to use for anyone:
https://cloud.fx.land/

@lidel lidel added status/blocked Unable to be worked further until needs are met need/author-input Needs input from the original author labels Jul 3, 2024
@ehsan6sha
Copy link
Contributor Author

Hey. Please let me know if anything else needs modification before being able to merge
Thnak you

@ehsan6sha
Copy link
Contributor Author

Hi, Just checking on this PR

@lidel
Copy link
Member

lidel commented Aug 11, 2024

Apologies for slow reply, this project is at the end of our release pipelines and not triaged often.

My understanding is the inclusion bar is to pass and be added to continously running https://github.com/ipfs-shipyard/pinning-service-compliance tests.

You can follow what Scaleway did (+share test token with us):

  1. Add Scaleway IPFS Pinning for compliance ipfs-shipyard/pinning-service-compliance#289
  2. feat: add scaleway pinning service ipfs-shipyard/pinning-service-compliance#333

That being said, there seems to be a problem with updating conformance report website at the moment, and to not block on that, I think as long npx @ipfs-shipyard/pinning-service-compliance -s <your_service_endpoint> <auth_token> passes, we can merge and release this.

@ehsan6sha to expedite, are you able to run test and post results here? Or share auth token with us on Slack DM.

@ehsan6sha
Copy link
Contributor Author

Apologies for slow reply, this project is at the end of our release pipelines and not triaged often.

My understanding is the inclusion bar is to pass and be added to continously running https://github.com/ipfs-shipyard/pinning-service-compliance tests.

You can follow what Scaleway did (+share test token with us):

  1. Add Scaleway IPFS Pinning for compliance ipfs-shipyard/pinning-service-compliance#289
  2. feat: add scaleway pinning service ipfs-shipyard/pinning-service-compliance#333

That being said, there seems to be a problem with updating conformance report website at the moment, and to not block on that, I think as long npx @ipfs-shipyard/pinning-service-compliance -s <your_service_endpoint> <auth_token> passes, we can merge and release this.

@ehsan6sha to expedite, are you able to run test and post results here? Or share auth token with us on Slack DM.

The report is available here: https://github.com/functionland/pinning-service/blob/main/api.cloud.fx.land.md

I also shared a test token in slack

@lidel lidel mentioned this pull request Aug 11, 2024
32 tasks
@lidel lidel changed the title Add Functionland Fula to List of Pinning Providers feat(remotepins): add Functionland Fula Aug 12, 2024
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/constants/pinning.js Outdated Show resolved Hide resolved
@@ -32,6 +32,12 @@ const pinningServiceTemplates = [
apiEndpoint: 'https://api.filebase.io/v1/ipfs',
visitServiceUrl: 'https://docs.filebase.com/api-documentation/ipfs-pinning-service-api'
},
{
name: 'Functionland',
icon: 'https://dweb.link/ipfs/bafybeidgnnvgm6i3pfzhjakgzcdwdbvwtmkkx7vzeiyvtk2b4oxis53vhm?filename=functionland.png',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just realized IPFS version is 5000x5000 pixels in size for some reason.
@ehsan6sha do you have SVG by any chance? If not, we should switch to 512x512.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provisionally, replaced 192k PNG with 7k SVG:

Suggested change
icon: 'https://dweb.link/ipfs/bafybeidgnnvgm6i3pfzhjakgzcdwdbvwtmkkx7vzeiyvtk2b4oxis53vhm?filename=functionland.png',
icon: 'https://dweb.link/ipfs/QmWYEmdYq9Ry2xtb69oZSPXb8Aos24kWdVecsT3txVe38E?filename=functionland.svg',

Let's see how it looks.

Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SVG looks fine, shipping.

@lidel lidel merged commit b998f3c into ipfs:main Aug 12, 2024
20 checks passed
@lidel lidel removed status/blocked Unable to be worked further until needs are met need/author-input Needs input from the original author labels Aug 12, 2024
ipfs-gui-bot pushed a commit that referenced this pull request Aug 12, 2024
## [4.3.0](v4.2.1...v4.3.0) (2024-08-12)

 CID `bafybeihatzsgposbr3hrngo42yckdyqcc56yean2rynnwpzxstvdlphxf4`

 ---

### Features

* **remotepins:** add Functionland Fula ([#2242](#2242)) ([b998f3c](b998f3c))

### Bug Fixes

* improve app's bootstrap HTML metadata ([#2168](#2168)) ([9c10520](9c10520))
* loading empty content ([#2237](#2237)) ([e81d132](e81d132))

### Trivial Changes

* **ci:** dnslink update on .tech tld ([222053a](222053a))
* **ci:** stop updating webui.ipfs.io ([5b06c3f](5b06c3f))
* **deps:** bump actions/checkout from 3.6.0 to 4.1.2 ([#2213](#2213)) ([d028190](d028190))
* **deps:** bump actions/github-script from 6 to 7 ([#2197](#2197)) ([7342cfa](7342cfa))
* **deps:** bump axios, @storybook/test-runner, bundlesize and wait-on ([#2215](#2215)) ([fbbe5ff](fbbe5ff))
* **deps:** bump ip from 1.1.8 to 1.1.9 ([#2211](#2211)) ([d73e798](d73e798))
* **deps:** bump stefanzweifel/git-auto-commit-action from 4.16.0 to 5.0.1 ([#2222](#2222)) ([c6159c3](c6159c3))
* pull transifex translations ([#2220](#2220)) ([35f8aae](35f8aae))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 4.3.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants