Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: bandwith stats have the colors the wrong way around #953

Closed
nonchip opened this issue Feb 5, 2019 · 5 comments
Closed

UI: bandwith stats have the colors the wrong way around #953

nonchip opened this issue Feb 5, 2019 · 5 comments

Comments

@nonchip
Copy link

nonchip commented Feb 5, 2019

I'm on Revision 1ed2020, and I just noticed on the Status tab of the webUI the colors for inbound/outbound traffic differ:

  • "Network Traffic" shows inbound in orange, outbound in blue
  • "Bandwidth over time" shows inbound in blue, outbound in orange

those should probably be swapped so they match up for easier recognition at a glance.

@fsdiogo
Copy link
Contributor

fsdiogo commented Feb 5, 2019

Hi @nonchip, this has been fixed in v2.2.0!

@fsdiogo fsdiogo closed this as completed Feb 5, 2019
@nonchip
Copy link
Author

nonchip commented Feb 5, 2019

@fsdiogo i just realized my distro didn't update the package since 0.4.18, thanks for pointing out :P

@nonchip
Copy link
Author

nonchip commented Feb 5, 2019

@fsdiogo actually, that's also the latest release on dist.ipfs.io and the go-ipfs github repo, am I missing something here? 0.o

EDIT: ok, found the problem, makes sense, the webui vs daemon are updated independently, and https://github.com/ipfs/go-ipfs/blob/master/core/corehttp/webui.go#L4 is still not a ipns address.

@fsdiogo
Copy link
Contributor

fsdiogo commented Feb 5, 2019

Well, what's happening is that you're using the latest "production" version of go-ipfs which has a specific version of the Web UI (the one you're using).

With every release of the Web UI we PR the repos that use it, such as go-ipfs (ipfs/kubo#5855, ipfs/kubo#5899, ipfs/kubo#5928), but then it's up to those repos to be released so you can access the newest Web UI through them.

So, the next version of go-ipfs will already have the newer Web UI!

@nonchip
Copy link
Author

nonchip commented Feb 5, 2019

guess i'll just wait then (and hope it's gonna become a name instead of a hash, it already seems to be on TXT _dnslink.webui.ipfs.io. anyway, so it'll be a bit more future proof).

by the way, note just going to webui.ipfs.io doesn't work if you use the companion plugin, because then it rewrites your url to use the gateway instead of api port, and specifying it manually breaks the CORS rules.

just checked, disabling the companion still breaks CORS, so um, the link in the v2.2.0 post does nothing :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants