Skip to content
This repository was archived by the owner on Mar 23, 2023. It is now read-only.

fix: make it-all a dependency #6

Merged
merged 1 commit into from
Jan 4, 2022
Merged

fix: make it-all a dependency #6

merged 1 commit into from
Jan 4, 2022

Conversation

kevinji
Copy link
Contributor

@kevinji kevinji commented Dec 16, 2021

it-all is directly used in src/base.js, so it should be a dependency, not a devDependency. This fixes an error that yarn pnp raises due to accessing an undeclared dependency.

@welcome
Copy link

welcome bot commented Dec 16, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@kevinji
Copy link
Contributor Author

kevinji commented Jan 4, 2022

@achingbrain since you look like you're the only contributor, do you mind reviewing this?

@achingbrain achingbrain merged commit 1139507 into ipfs:master Jan 4, 2022
@achingbrain
Copy link
Member

Thanks for the fix, sorry I missed your PR!

@kevinji kevinji deleted the patch-1 branch January 4, 2022 18:40
@github-actions
Copy link

github-actions bot commented Jan 4, 2022

🎉 This PR is included in version 1.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants