This repository was archived by the owner on Mar 23, 2023. It is now read-only.
fix: fix ShardingDatastore creation #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the ShardingDatastore work like the other datastore, where we can just do `const store = new Datastore()` and `await store.open()` without the need of extra static methods. The old static methods should work as expected they are deprecated now we can make a breaking change and remove them all together. What do you think ?
achingbrain
approved these changes
Jan 22, 2021
Sounds good to me |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the ShardingDatastore work like the other datastore, where we can just do
const store = new Datastore()andawait store.open()without the need of extra static methods.The old static methods should work as expected they are deprecated now we can make a breaking change and remove them all together. What do you think ?