This repository was archived by the owner on Mar 23, 2023. It is now read-only.
fix: use streaming methods where possible #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The base adapter class calls `.put` repeatedly when `.putMany` is invoked in order to reduce the number of methods a datastore has to implement to be compatible with the datastore interface. This hurts performance where datastores wrap other datastores that can take advantage of the streaming methods to exectute certain operations in parallel. The change here is to call streaming methods from streaming methods where it makes sense to do so, instead of letting the adapter class convert streaming method invocations into serial method invocations.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base adapter class calls
.putrepeatedly when.putManyis invokedin order to reduce the number of methods a datastore has to implement to
be compatible with the datastore interface.
This hurts performance where datastores wrap other datastores that can
take advantage of the streaming methods to exectute certain operations in
parallel.
The change here is to call streaming methods from streaming methods where
it makes sense to do so, instead of letting the adapter class convert
streaming method invocations into serial method invocations.