Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

feat: types #62

Merged
merged 11 commits into from
Jan 22, 2021
Merged

feat: types #62

merged 11 commits into from
Jan 22, 2021

Conversation

hugomrdias
Copy link
Member

@hugomrdias hugomrdias commented Dec 11, 2020

Adds types support

Adds types support
@hugomrdias
Copy link
Member Author

ready

strategy:
matrix:
os: [windows-latest, ubuntu-latest, macos-latest]
node: [12, 14]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
node: [12, 14]
node: [14, 15]

This should be 14 & 15 as that's LTS/Current. Going through and updating all of these repos every time there's a new node version is going to be an enormous pain, can it be automated?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That issue looks like it's stalled and the linked PR is stale and also contains a bunch of irrelevant changes which will harm its chances of being merged.

I think we'll need to do something ourselves for the time being.

@achingbrain achingbrain merged commit de519dd into master Jan 22, 2021
@achingbrain achingbrain deleted the feat/ts-types branch January 22, 2021 19:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants