Windows interop

[richardschneider]

See the discussion at #623

[daviddias]

Pulling discussion from #623 (comment)

---

@richardschneider mind opening a PR on js-ipfs-api?

diag.sys [Error: this operation is not supported on your platform]

We can have a flag that disables this test for Windows, it's ok.

dial attempt failed: context deadline exceeded

Do you know what it was trying to dial to?

.swarm.addrs Uncaught AssertionError: expected [] not to be empty

Sounds like this failed due to the previous dial fail

.swarm.peers timeout

Increase the timeout?

various issues with addFromFs

Reported here #408

a few tests are getting different hash IDs

Weird, which ones?

[daviddias]

Test output from @richardschneider

https://github.com/ipfs/js-ipfs-api/files/1465164/test-results.txt

[thisconnect]

There are a few slashes '/' in get-files-stream.js https://github.com/ipfs/js-ipfs-api/blob/master/src/utils/get-files-stream.js#L49 and possible in other places. Not sure if they matter but could you try with path.sep https://nodejs.org/api/path.html#path_path_sep ?

[richardschneider]

@thisconnect Thanks. I plan to work on this code today. There are two issues:

• the file name is resolved so will have os-specific separator
• glob wants forward slashes

[richardschneider]

On my local windows I'm getting ECONNREFUSED in https://github.com/ipfs/js-ipfs-api/blob/master/test/ipfs-factory/client.js

It is trying to talk to localhost:55155
Who is listening to this port? And why is it hardcoded?

[richardschneider]

Solved the port 55155 issue. I was using mocha directly to only run a few tests. The tests do NOT spin up a test server. That is aegir responsibility, so I didn't have a test server. Better error messages could have saved me a few hours.

[richardschneider]

@diasdavid I have made the minor changes to get this running on Windows.

All the red lights have nothing to do with Windows and are pre-existing problems.

[daviddias]

👍

[daviddias]

👍

[daviddias]

I haven't seen this error before:

[richardschneider]

The code can NOT handle x-stream-error correctly. See request-api

// TODO: This needs reworking.
// this is a chicken and egg problem -
// 1) we can't get Trailer headers unless the response ends
// 2) we can't propagate the error, because the response stream
// is closed
// (perhaps we can workaround this using pull-streams)