Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistencies discovered in #261 #303

Open
Gozala opened this issue Mar 10, 2021 · 0 comments
Open

Fix inconsistencies discovered in #261 #303

Gozala opened this issue Mar 10, 2021 · 0 comments
Labels
status/ready Ready to be worked

Comments

@Gozala
Copy link
Contributor

Gozala commented Mar 10, 2021

  1. Should be timeout instead (as per comment here https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r589357353)

    // TODO: Should this be a timeout options insetad ?
    // @ts-expect-error - 'maxTimeout' does not exist in type
    maxTimeout: CONSTANTS.providerRequestTimeout,

  2. equality check on messages seems to have a bug (for more context see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587863878)

    // @TODO - Is this a bug ?
    // @ts-expect-error - isMap equals map values to be objects not numbers
    !isMapEqual(this.blockPresences, other.blockPresences)

  3. Want list entries sorting has a bug (See https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587867673)

  4. Need to specify want type when adding it to wantlist (see https://github.com/ipfs/js-ipfs-bitswap/pull/261/files#r587865473)

@Gozala Gozala added the need/triage Needs initial labeling and prioritization label Mar 10, 2021
@jacobheun jacobheun added status/ready Ready to be worked and removed need/triage Needs initial labeling and prioritization labels Mar 15, 2021
@BigLep BigLep added need/triage Needs initial labeling and prioritization and removed need/triage Needs initial labeling and prioritization labels Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/ready Ready to be worked
Projects
None yet
Development

No branches or pull requests

3 participants