Skip to content
This repository has been archived by the owner on Aug 11, 2021. It is now read-only.

feat: support passing AbortSignals to the configured repo #89

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

achingbrain
Copy link
Member

This is so the user can signal that they are no longer interested in the results of the operation and system components can stop trying to fulfil it.

This is so the user can signal that they are no longer interested
in the results of the operation and system components can stop
trying to fulfil it.
@achingbrain achingbrain requested a review from vmx April 15, 2020 09:53
Copy link
Member

@vmx vmx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one seems to depend on Bitswap and repo (althought passing additional things into something which doesn't expect them usually isn't an issue in JS). It would be good to get instruction on when to merge and release.

@achingbrain
Copy link
Member Author

I don't think there's any harm in releasing, they will just ignore the extra option object for the time being.

@vmx vmx merged commit 0c5f17c into master Apr 16, 2020
@vmx vmx deleted the feat/support-aborting-requests branch April 16, 2020 14:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants