-
Notifications
You must be signed in to change notification settings - Fork 298
Conversation
package.json
Outdated
@@ -84,7 +84,7 @@ | |||
"eslint-plugin-react": "^7.11.1", | |||
"go-ipfs-dep": "~0.4.18", | |||
"interface-ipfs-core": "~0.96.0", | |||
"ipfsd-ctl": "~0.40.0", | |||
"ipfsd-ctl": "github:ipfs/js-ipfsd-ctl#feat/support-profile", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's missing to have this shipped? :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing, I just didn't PR yet!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually missed what this “test profile” was in the beginning. Super rad to see this go-IPFS feature.
Would love to see this on interop tests (and see if it doesn’t break my router anymore).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I should have explained better! For everyone else, you can pass a "profile" option to ipfs init
:
'test' - Reduces external interference of IPFS daemon, this is useful when using the daemon in test environments.
https://docs.ipfs.io/reference/api/cli/#ipfs-init
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome test speed improvement! 💪
@alanshaw could you also try: |
For reference posting what EDIT: Upps, I didn't notice that you've added it to top comment after the call. |
I updated this PR to use the "test" profile in all tests (not just the interface-ipfs-core tests). ✨ 2m43.800s ✨ @Kubuxu, I think I might be doing something wrong - passing "test,badgerds" for the test profile makes it slow again - I'm guessing these aren't being applied the way I'm specifying them - do I need multiple |
Checking it manually, they seem to be both applied when done in this way.
That is awesome. |
@Kubuxu thank you for the tip off :D |
Seems to be taking between ✨ 3-4 mins ✨ in Jenkins CI https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-http-client/detail/PR-942/6/pipeline/257 |
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
184fe48
to
302a1b4
Compare
Urh, this is kind of amazing, it took the node.js test time down from 13m49.208s to 5m15.992s 😱 (for me locally)
For reference, this is what using the "test" profile does: https://github.com/ipfs/go-ipfs-config/blob/master/profile.go#L68-L85
resolves #593
Depends on: