This repository was archived by the owner on Sep 28, 2021. It is now read-only.
fix: use .cid property before falling back to .multihash #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DAGLinks have a `.cid` property, use that instead of `.multihash`. From the comment above the line it looks like this was the original intention but for whatever reason it was still using `.multihash`.
|
This PR has been submitted from my fork as for whatever reason I don't have contributor access to this repo. |
vasco-santos
approved these changes
Nov 9, 2018
|
I added the |
achingbrain
deleted the
use-cid-property-before-falling-back-to-multihash
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAGLinks have a
.cidproperty, use that instead of.multihash.From the comment above the line it looks like this was the original intention but for whatever reason it was still using
.multihash.