This repository has been archived by the owner on Sep 28, 2021. It is now read-only.
refactor: use new IPFS async/await APIs #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasco-santos
approved these changes
Jan 7, 2020
|
@vasco-santos this is another one where the tests probably shouldn't depend on IPFS. The new js-ipfs depends on this change so this module needs to be released before we can release js-ipfs. |
|
Agree! I will open an issue to refactor the tests So, I will release this for now |
|
@vasco-santos if it wasn't obvious, this is a breaking change! |
|
Yep, otherwise It should be in the commit! but I will add it on merge |
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new IPFS async/await APIs.
Also upgrades
ipfsd-ctldep and test setup.