Skip to content
This repository has been archived by the owner on Apr 29, 2020. It is now read-only.

Make the HAMT a standalone module that can be used by other libraries #1

Closed
daviddias opened this issue Nov 21, 2018 · 5 comments
Closed

Comments

@daviddias
Copy link
Contributor

Pretty please 🥺🙏🏽

@achingbrain
Copy link
Collaborator

@daviddias
Copy link
Contributor Author

Didn't know about those. We made the JS HAMT way after the GO HAMT

@achingbrain
Copy link
Collaborator

Shame they got the good name on npm already!

@mikeal
Copy link

mikeal commented Nov 21, 2018

Which HAMT encoding are we using? The current one in the dag-pb based unixfs or the one Filecoin is using and, I assume, unixfs-v2 will use https://github.com/ipfs/go-hamt-ipld ?

@achingbrain
Copy link
Collaborator

This module uses hamt-sharding which was extracted from the js-unixfs-engine module and is a vanilla HAMT.

I hadn't seen go-hamt-ipld but it looks like it uses a CHAMP style HAMT which might or might not be an improvement.

For unixfs-v2 do you know if anyone's done any real-world benchmarks to compare the performance? If not it's probably something we should look at.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants