Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsipfs add fails on inputs larger than 1GiB when rabin is specified #41

Closed
ribasushi opened this issue Jan 20, 2020 · 3 comments
Closed

Comments

@ribasushi
Copy link

Reproducible as:

~$ for onemegs in 1022 1023 1024 1025 ; do echo -n "$(( $onemegs * 1048576 )) bytes: "; dd if=/dev/zero bs=1048576 count=$onemegs 2>/dev/null | jsipfs add -n -q --chunker=rabin ; done
1071644672 bytes: QmQtWcWN3DKaRnPDYU7nsPEbrSH63Py7LFQfFJ7bKaWHNi
1072693248 bytes: QmNex7npXYN4CFR4ysL6VsBLvAt9CQjAiSpvTnGMiQhZ9k
1073741824 bytes: unreachable
1074790400 bytes: unreachable

~$ jsipfs --version
0.40.0
@ribasushi
Copy link
Author

@alanshaw actually... rabin outright does not converge with goipfs for a number of inputs. I say let's put this bug on ice for now, I will use go-ipfs as the "source of truth", and circle back to this once things are better validated.

In other words - we need to fix this one way or the other, but it seems there's more to fix than just a crash :(

@achingbrain achingbrain transferred this issue from ipfs-inactive/js-ipfs-unixfs-importer Feb 21, 2020
@ribasushi
Copy link
Author

rabin outright does not converge with goipfs for a number of inputs

That turned out to be #50

The original bug ( crash on > ~1GiB files ) seems to have been fixed by @hugomrdias' changes 🎉
I will close this ticket once the full convergence test finishes ( ~3 hours )

@ribasushi
Copy link
Author

This particular issue seems solved for good on 0.42.2-rc.4. Finding others sadly, but will make separate tickets for them shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant