Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to dag-pb that supports Uint8Array #65

Merged
merged 1 commit into from
Jul 23, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Jul 22, 2020

Updates to new dag-pb to incorporate changes that allows passing Uint8Arrays in place of node Buffers.

@achingbrain I'm not sure what's the deal with this file https://github.com/ipfs/js-ipfs-unixfs/blob/master/packages/ipfs-unixfs-exporter/package-lock.json but it doesn't seem to get updated when running npm install in the root & seems to break npm istall when run in the exporter dir.

@Gozala Gozala requested a review from achingbrain July 22, 2020 01:39
@achingbrain
Copy link
Member

Typically you wouldn't run npm install in the exporter dir, only in the root of the repo. Feel free to just delete the package-lock files locally and run install as they'd get regenerated anyway.

See DEVELOPMENT.md#clone-and-install-dependencies in the js-IPFS project for more.

@achingbrain achingbrain merged commit 5ffa2b3 into ipfs:master Jul 23, 2020
@Gozala
Copy link
Contributor Author

Gozala commented Jul 23, 2020

Typically you wouldn't run npm install in the exporter dir, only in the root of the repo. Feel free to just delete the package-lock files locally and run install as they'd get regenerated anyway.

See DEVELOPMENT.md#clone-and-install-dependencies in the js-IPFS project for more.

@achingbrain the reason I asked is because you seem to have deliberately published one here
https://github.com/ipfs/js-ipfs-unixfs/blob/master/packages/ipfs-unixfs-exporter/package-lock.json

Which is out of sync now. When I don npm install in the root package-lock.json isn't changing so I'm not exactly sure why it's there or if it's ok that it's out of sync.

@achingbrain
Copy link
Member

npm install ignores package-lock.json, only npm ci respects it.

It does read it though so if you're having problems, just delete package-lock.json and run npm i from the root of the repo.

It's published so we know what dependencies were used for a given release.

achingbrain pushed a commit that referenced this pull request Jul 24, 2020
Updates to new dag-pb to incorporate changes that allows passing `Uint8Array`s in place of node `Buffer`s.

BREAKING CHANGE: dag-pb Links property now returns DAGLink objects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants