Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: env/isTest #10

Merged
merged 1 commit into from
Sep 6, 2019
Merged

feat: env/isTest #10

merged 1 commit into from
Sep 6, 2019

Conversation

lidel
Copy link
Member

@lidel lidel commented Sep 5, 2019 •
edited
Loading

This PR unblocks ipfs/js-ipfs#2304

Adds isTest check to tell if runtime is part of tests:

process.env.NODE_ENV === 'test'

It does it in a way that works in browser without process.env polyfills

@lidel
feat: env/isTest
136b0e6 
Adds check to tell if runtime is part of tests

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel mentioned this pull request Sep 5, 2019
Merged
7 tasks
@hugomrdias hugomrdias merged commit 481aab1 into master Sep 6, 2019
@hugomrdias hugomrdias deleted the feat/isTest branch September 6, 2019 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lidel @hugomrdias