Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add json option to http #34

Merged
merged 4 commits into from
Apr 14, 2020
Merged

feat: add json option to http #34

merged 4 commits into from
Apr 14, 2020

Conversation

hugomrdias
Copy link
Member

This PR

  • updates deps
  • adds echo-server to be used in tests here and others repos like js-ipfs
  • adds get-port to pick an available port when default is in use
    • further improvements to aegir will allow for dynamic ports
  • add json option to http.js

@hugomrdias hugomrdias requested a review from achingbrain April 8, 2020 14:22
achingbrain
achingbrain reviewed Apr 8, 2020
View reviewed changes
src/echo-server.js Outdated Show resolved Hide resolved
@hugomrdias hugomrdias requested a review from achingbrain April 8, 2020 15:15
@hugomrdias hugomrdias force-pushed the feat/deps-http-echo-server-port branch from 057b9bc to 68234d2 Compare April 14, 2020 11:03
@hugomrdias hugomrdias changed the title feat: update deps, add echo-server and get-port feat: add json option to http Apr 14, 2020
@hugomrdias hugomrdias merged commit 070a456 into master Apr 14, 2020
@hugomrdias hugomrdias deleted the feat/deps-http-echo-server-port branch April 14, 2020 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achingbrain achingbrain Awaiting requested review from achingbrain

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugomrdias @achingbrain