Merge pull request #1 from nginnever/magic-externals

test(browser): Use externals for node-forge

Author: nginnever

Diff for: karma.conf.js

@@ -1,15 +1,13 @@
 module.exports = function (config) {
   var path = require('path')
-  var node_modules_dir = path.join(__dirname, 'node_modules')
-  var deps = [
-    'peer-id/deps/forge.bundle.js'
-  ]
-  
+  var nodeForgePath = path.resolve(__dirname, 'node_modules/peer-id/deps/forge.bundle.js')
+
   config.set({
     basePath: '',
     frameworks: ['mocha'],
 
     files: [
+      nodeForgePath,
       'tests/test-core/browser.js'
     ],
 
@@ -19,21 +17,20 @@ module.exports = function (config) {
 
     webpack: {
       resolve: {
-        extensions: ['', '.js', '.json'],
-        alias: {'node-forge': node_modules_dir+'/peer-id/deps/forge.bundle.js' }
+        extensions: ['', '.js', '.json']
       },
       externals: {
-        fs: '{}'
+        fs: '{}',
+        'node-forge': 'forge'
       },
       node: {
         Buffer: true
       },
       module: {
         loaders: [
           { test: /\.json$/, loader: 'json' }
-        ],
-        noParse: []
-      },
+        ]
+      }
     },
 
     webpackMiddleware: {
@@ -50,9 +47,4 @@ module.exports = function (config) {
     browsers: process.env.TRAVIS ? ['Firefox'] : ['Chrome'],
     singleRun: true
   })
-
-  deps.forEach(function (dep) {
-    var depPath = path.resolve(node_modules_dir, dep)
-    config.webpack.module.noParse.push(depPath)
-  })
 }

Diff for: package.json

@@ -59,7 +59,7 @@
     "rimraf": "^2.4.4",
     "standard": "^5.4.1",
     "transform-loader": "^0.2.3",
-    "webpack": "^2.0.5-beta"
+    "webpack": "^2.0.7-beta"
   },
   "dependencies": {
     "bl": "^1.0.0",