refactor: convert id API to async/await (#2665)

Author: Alan Shaw

Diff for: src/core/components/id.js

@@ -1,20 +1,19 @@
 'use strict'
 
-const callbackify = require('callbackify')
 const pkgversion = require('../../../package.json').version
 
-module.exports = function id (self) {
-  return callbackify(async () => { // eslint-disable-line require-await
+module.exports = ({ peerInfo }) => {
+  return async function id () { // eslint-disable-line require-await
     return {
-      id: self._peerInfo.id.toB58String(),
-      publicKey: self._peerInfo.id.pubKey.bytes.toString('base64'),
-      addresses: self._peerInfo.multiaddrs
+      id: peerInfo.id.toB58String(),
+      publicKey: peerInfo.id.pubKey.bytes.toString('base64'),
+      addresses: peerInfo.multiaddrs
         .toArray()
         .map((ma) => ma.toString())
         .filter((ma) => ma.indexOf('ipfs') >= 0)
         .sort(),
       agentVersion: `js-ipfs/${pkgversion}`,
       protocolVersion: '9000'
     }
-  })
+  }
 }

Diff for: src/core/components/index.js

@@ -7,6 +7,7 @@ exports.bitswap = {
   wantlist: require('./bitswap/wantlist')
 }
 exports.config = require('./config')
+exports.id = require('./id')
 exports.init = require('./init')
 exports.ping = require('./ping')
 exports.start = require('./start')

Diff for: src/core/components/init.js

@@ -300,6 +300,7 @@ function createApi ({
   const api = {
     add,
     config: Commands.config({ repo }),
+    id: Commands.id({ peerInfo }),
     init: () => { throw new AlreadyInitializedError() },
     start
   }

Diff for: src/core/components/start.js

@@ -137,6 +137,7 @@ function createApi ({
       wantlist: Commands.bitswap.wantlist({ bitswap })
     },
     config: Commands.config({ repo }),
+    id: Commands.id({ peerInfo }),
     init: () => { throw new AlreadyInitializedError() },
     ping: Commands.ping({ libp2p }),
     pubsub: libp2p.pubsub

Diff for: src/core/components/stop.js

@@ -99,6 +99,7 @@ function createApi ({
   const api = {
     add,
     config: Commands.config({ repo }),
+    id: Commands.id({ peerInfo }),
     init: () => { throw new AlreadyInitializedError() },
     start,
     stop: () => apiManager.api