fix: do not republish self key twice

ipfs · Apr 27, 2021 · 26a46ec · 26a46ec
1 parent c79d3d6
commit 26a46ec
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 0 deletions.
diff --git a/packages/ipfs-core/src/ipns/republisher.js b/packages/ipfs-core/src/ipns/republisher.js
@@ -138,6 +138,9 @@ class IpnsRepublisher {
         const keys = await this._keychain.listKeys()
 
         for (const key of keys) {
+          if (key.name === 'self') {
+            continue
+          }
           const pem = await this._keychain.exportKey(key.name, pass)
           const privKey = await crypto.keys.import(pem, pass)
 

diff --git a/packages/ipfs-core/test/name.spec.js b/packages/ipfs-core/test/name.spec.js
@@ -50,6 +50,26 @@ describe('name', function () {
       expect(republisher._republishEntries.calledTwice).to.equal(true)
     })
 
+    it('should not republish self key twice', async function () {
+      const mockKeychain = {
+        listKeys: () => Promise.resolve([{ name: 'self' }])
+      }
+      republisher = new IpnsRepublisher(sinon.stub(), sinon.stub(), sinon.stub(), mockKeychain, {
+        initialBroadcastInterval: 500,
+        broadcastInterval: 1000,
+        pass: 'pass'
+      })
+      republisher._republishEntry = sinon.stub()
+
+      await republisher.start()
+
+      expect(republisher._republishEntry.calledOnce).to.equal(false)
+
+      // Initial republish should happen after ~500ms
+      await delay(750)
+      expect(republisher._republishEntry.calledOnce).to.equal(true)
+    })
+
     it('should error if run republish again', async () => {
       republisher = new IpnsRepublisher(sinon.stub(), sinon.stub(), sinon.stub(), sinon.stub(), {
         initialBroadcastInterval: 50,