chore: fix monitoring (#3972)

Allow GET requests for prom stats and return correct response type

Author: achingbrain

.github/workflows/test.yml

@@ -312,6 +312,7 @@ jobs:
     name: Test example ${{ matrix.example.name }}
     needs: build
     runs-on: ubuntu-latest
+    continue-on-error: true
     strategy:
       matrix:
         example:

packages/ipfs-http-server/src/api/routes/debug.js

@@ -7,7 +7,7 @@ const gauge = new client.Gauge({ name: 'number_of_peers', help: 'the_number_of_c
 
 // Endpoint for handling debug metrics
 export default [{
-  method: 'POST',
+  method: 'GET',
   path: '/debug/metrics/prometheus',
   /**
    * @param {import('../../types').Request} request
@@ -23,7 +23,9 @@ export default [{
 
     gauge.set(peers.length)
 
-    return h.response(client.register.metrics())
+    const metrics = await client.register.metrics()
+
+    return h.response(metrics)
       .type(client.register.contentType)
   }
 }]

packages/ipfs-http-server/src/index.js

@@ -171,9 +171,16 @@ export class HttpApi {
           return h.continue
         }
 
-        if (request.method === 'get' && (request.path.startsWith('/ipfs') || request.path.startsWith('/webui'))) {
-          // allow requests to the webui
-          return h.continue
+        if (request.method === 'get') {
+          if (request.path.startsWith('/ipfs') || request.path.startsWith('/webui')) {
+            // allow requests to the gateway and webui
+            return h.continue
+          }
+
+          if (process.env.IPFS_MONITORING && request.path.startsWith('/debug')) {
+            // allow requests to prometheus stats when monitoring is enabled
+            return h.continue
+          }
         }
 
         throw Boom.methodNotAllowed()