This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: error when command is unknown #2916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since yargs v14, using `.parse(command)` with an unknown command causes an [error to be thrown](yargs/yargs#1419) instead of the help text being printed. One solution is to use `.argv` instead of `.parse(command)` but we use the `.parse(command)` variant to enable testing as the passed command is evaluated rather than `process.argv`, which is what happens when you call `.argv`. Instead if we detect a error caused by an unknown command, use the parser to show help instead of version of yargs that had `.parse(command)` called on it.
hugomrdias
approved these changes
Mar 13, 2020
mistakia
pushed a commit
to mistakia/js-ipfs
that referenced
this pull request
Mar 22, 2020
Since yargs v14, using `.parse(command)` with an unknown command causes an [error to be thrown](yargs/yargs#1419) instead of the help text being printed. One solution is to use `.argv` instead of `.parse(command)` but we use the `.parse(command)` variant to enable testing as the passed command is evaluated rather than `process.argv`, which is what happens when you call `.argv`. Instead if we detect a error caused by an unknown command, use the parser to show help instead of version of yargs that had `.parse(command)` called on it.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since yargs v14, using
.parse(command)with an unknown command causes an error to be thrown instead of the help text being printed.One solution is to use
.argvinstead of.parse(command)but we use the.parse(command)variant to enable testing as the passed command is evaluated rather thanprocess.argv, which is what happens when you call.argv.Instead if we detect a error caused by an unknown command, use the parser to show help instead of version of yargs that had
.parse(command)called on it.