Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: pass headers to request #3018

Merged
merged 4 commits into from
May 5, 2020
Merged

fix: pass headers to request #3018

merged 4 commits into from
May 5, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented May 2, 2020 •
edited
Loading

Somewhere along the line we stopped passing headers to the underlying
request library which means people can't use http auth etc to try to
secure their API servers.

Fixes #3017

Depends on:

@achingbrain
fix: pass headers to request
b9d8dd8 
Somewhere along the line we stopped passing headers to the underlying
request library which means people can't use http auth etc to try to
secure their API servers.

Fixes #3017

Depends on:

- [ ] ipfs/js-ipfs-utils#41
@achingbrain achingbrain mentioned this pull request May 2, 2020
Closed
@achingbrain achingbrain merged commit 3ba00f8 into master May 5, 2020
@achingbrain achingbrain deleted the fix/pass-headers-to-request branch May 5, 2020 15:39
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
@achingbrain
fix: pass headers to request (#3018)
8ddb317 
Somewhere along the line we stopped passing headers to the underlying
request library which means people can't use http auth etc to try to
secure their API servers.

Fixes #3017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hugomrdias hugomrdias hugomrdias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ipfs-http-client: files.write loses all headers after util/multipart header merge
2 participants
@achingbrain @hugomrdias