Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: use fetch in electron renderer and electron-fetch in main #3251

Merged
merged 11 commits into from
Oct 10, 2020

Conversation

achingbrain
Copy link
Member

@achingbrain achingbrain commented Aug 27, 2020

Roughly halves the amount of time it takes to run electron tests.

Depends on:

@jacobheun jacobheun added the status/blocked Unable to be worked further until needs are met label Sep 3, 2020
@jacobheun jacobheun removed the status/blocked Unable to be worked further until needs are met label Sep 24, 2020
achingbrain added a commit that referenced this pull request Sep 28, 2020
Decomposes the main ipfs module into separate core, http api server and
cli modules which encapsulate the different parts of ipfs.

This allows us to:

1. Omit modules/code/dependencies if they aren't going to be used
2. Reduces the amount of tests being run in series

The average time of a CI job has gone from just under 20 minutes to just
over 10 minutes.  Outliers here are electron tests (which should be fixed
by #3251) and webworker tests which will need further investigation.

Fixes #2678
Fixes #2877
Roughly halves the amount of time it takes to run electron tests.
@achingbrain
Copy link
Member Author

achingbrain commented Oct 9, 2020

Blocked on arantes555/electron-fetch#30

I published a temporary fork so we can finish this.

@achingbrain achingbrain changed the title chore: run electron tests on linux fix: use fetch in electron renderer and electron-fetch in main Oct 10, 2020
@achingbrain achingbrain merged commit 639d71f into master Oct 10, 2020
@achingbrain achingbrain deleted the chore/run-electron-on-linux branch October 10, 2020 09:37
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
Decomposes the main ipfs module into separate core, http api server and
cli modules which encapsulate the different parts of ipfs.

This allows us to:

1. Omit modules/code/dependencies if they aren't going to be used
2. Reduces the amount of tests being run in series

The average time of a CI job has gone from just under 20 minutes to just
over 10 minutes.  Outliers here are electron tests (which should be fixed
by #3251) and webworker tests which will need further investigation.

Fixes #2678
Fixes #2877
SgtPooki referenced this pull request in ipfs/js-kubo-rpc-client Aug 18, 2022
Lets us run test on Linux which roughly halves the amount of time Electron CI tasks take.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants