Skip to content
This repository was archived by the owner on Feb 12, 2024. It is now read-only.

ipfs add zero filled uint8 fails against go #3542

Closed
hugomrdias opened this issue Feb 9, 2021 · 2 comments
Closed

ipfs add zero filled uint8 fails against go #3542

hugomrdias opened this issue Feb 9, 2021 · 2 comments
Assignees
Labels
effort/days Estimated to take multiple days, but less than a week env:Firefox exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) kind/maybe-in-helia need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked

Comments

@hugomrdias
Copy link
Member

This test https://github.com/ipfs/js-ipfs/blob/master/packages/interface-ipfs-core/src/add.js#L84 fails running the interface tests against go-ipfs in firefox ONLY.

This is the data used in the test https://github.com/ipfs/js-ipfs/blob/master/packages/interface-ipfs-core/src/utils/index.js#L26, changing the input to something like https://github.com/ipfs/js-ipfs/blob/master/packages/interface-ipfs-core/test/fixtures/test-folder/holmes.txt makes the test pass.

dag from go-ipfs

chrome
Screenshot 2021-02-09 at 12 19 42

firefox
Screenshot 2021-02-09 at 12 23 25

In this PR #3528 i changed the input data to make the test pass because it looks like this only happens with 0 filled buffers, but this needs a real fix.

@hugomrdias hugomrdias added kind/bug A bug in existing code (including security flaws) status/ready Ready to be worked P2 Medium: Good to have, but can wait until someone steps up env:Firefox need/triage Needs initial labeling and prioritization exp/intermediate Prior experience is likely helpful effort/days Estimated to take multiple days, but less than a week and removed need/triage Needs initial labeling and prioritization labels Feb 9, 2021
@SgtPooki SgtPooki self-assigned this May 17, 2023
@SgtPooki SgtPooki moved this to 🥞 Todo in js-ipfs deprecation May 17, 2023
@SgtPooki SgtPooki moved this from 🥞 Todo to ✅ Done in js-ipfs deprecation May 17, 2023
@SgtPooki SgtPooki moved this from ✅ Done to 🛑 Blocked in js-ipfs deprecation May 17, 2023
@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterward (see #4336).

@achingbrain to ensure that we have tests in helia that confirm this is not a problem

@SgtPooki SgtPooki added need/maintainer-input Needs input from the current maintainer(s) kind/maybe-in-helia and removed kind/wontfix labels May 26, 2023
@SgtPooki SgtPooki assigned achingbrain and unassigned SgtPooki May 26, 2023
@achingbrain
Copy link
Member

This is fixed in Helia, please open an issue there if the problem persists.

@github-project-automation github-project-automation bot moved this from 🛑 Blocked to ✅ Done in js-ipfs deprecation May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
effort/days Estimated to take multiple days, but less than a week env:Firefox exp/intermediate Prior experience is likely helpful kind/bug A bug in existing code (including security flaws) kind/maybe-in-helia need/maintainer-input Needs input from the current maintainer(s) P2 Medium: Good to have, but can wait until someone steps up status/ready Ready to be worked
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants